feat!: Update to Bevy 0.16 #422
Conversation
alexparlett
force-pushed
the
bevy_0.16
branch
2 times, most recently
from
81d34b7 to
1e87793
Compare
* Move from utils::HashMap to platform::collections::HashMap * Change to IntoSchedules vs IntoSystems * Change in namespaces
|
|
Is there anything holding this up? Formatting needs to be fixed up, anything else to do? |
|
I'm curious too about the fate of this PR. |
|
Bump on getting this landed? |
|
Looking at this now, it looks like there is still some work left on the codegen side which is currently failing. Did you update the generated bindings manually 👀 |
Bencher Report
|
The good news is it seems the new rustup version didn't break the codegen crate (i.e. it does not require a Codegen seems to need a few small adjustments and we should be good to go |
| @@ -96,6 +95,8 @@ impl WorldAccessGuard<'_> { | |||
| DynamicComponent::STORAGE_TYPE, | |||
| Layout::new::<DynamicComponent>(), | |||
| needs_drop::<DynamicComponent>().then_some(|x| x.drop_as::<DynamicComponent>()), | |||
| true, | |||
There was a problem hiding this comment.
I wonder if we need to consider specializing clone here, but I don't think so, the vanilla derive(Component) seems to do the same thing for all components I looked at
Summary
This introduces Bevy 0.16 compatibility.
We should probably in a follow up move to the bevy::platform::collections instead of using std to try and align as closely as possible with the no std approach bevy is taking but i didn't want to do it in this one.
Need to quickly restore the ordering where my ide aligned them with the interface order, but thought it would be good to get visibility on the changes.
Notes
bevy_console is pointing at a branch - there is https://github.com/RichoDemus/bevy-console/pull/88/files awaiting review which would allow us to change this.